Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python to 3.11 #1030

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Upgrade python to 3.11 #1030

wants to merge 11 commits into from

Conversation

nickmoreton
Copy link
Contributor

@nickmoreton nickmoreton commented Aug 6, 2024

Replace PR: #998

When merged this will upgrade python to 3.11 using the bookworm image tag

Additions.

  • Upgrade poetry
  • Upgrade dependencies reported by trivy
  • Add pyupgrade + pre-commit hook
  • Add poetry pre-commit hook

Changes:

  • Update upgrading docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some clean up on this file. We don't need to keep the notes about previous Wagtail versions.

@nickmoreton nickmoreton mentioned this pull request Aug 6, 2024
@engineervix
Copy link
Member

The python version can also be updated here:

- Python, version 3.6.9 or up

3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 it's nice that we are not locking down to a specific patch version. This will capture whatever 3.11.x version is availble.

Copy link
Member

@engineervix engineervix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickmoreton changes look good to me and running ok locally.
Just a small update in the README to specify the required python version.

@nickmoreton nickmoreton added the on-dev Flag to state if this code is on the dev site label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-dev Flag to state if this code is on the dev site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants