Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3766 - Accessibiity: Design System & Colour Contrast #1010

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

patrickcuagan
Copy link
Collaborator

Ticket: https://torchbox.monday.com/boards/1472452416/pulses/1472503766

This PR updates all xxxs, xxs, and xs font sizes to 18px. We also remove some font-size: map-get($large-font-sizes, xxs); as they're all now 18px.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.95%. Comparing base (086956b) to head (e2e456a).
Report is 87 commits behind head on master.

Current head e2e456a differs from pull request most recent head 837b23a

Please upload reports for the commit 837b23a to get more accurate results.

Files Patch % Lines
rca/editorial/models.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1010       +/-   ##
===========================================
+ Coverage   52.86%   73.95%   +21.08%     
===========================================
  Files         163      616      +453     
  Lines        7856     9387     +1531     
  Branches      175        0      -175     
===========================================
+ Hits         4153     6942     +2789     
+ Misses       3577     2445     -1132     
+ Partials      126        0      -126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chris-lawton
Copy link
Member

The code looks good. I imagine that the components will need testing on staging to make sure that they work and display correctly with the increased font size : )

@patrickcuagan patrickcuagan merged commit 9918c63 into master Jun 10, 2024
6 checks passed
@patrickcuagan patrickcuagan deleted the updates/3766-design-system branch June 10, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants