External lua option: variables unification, propagation, export. #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch is using external Lua/Rocks (like , the case of current luarocks .deb where LUA_LIBDIR is not actually pointing to Lua libs.)
…INCDIR) etc. Lua variables are exported so Torch modules do not have to have the whole shebang of LuaRocks valuables passed to them. They only need to know where to find Torch cmake exports. Some plumbing to propagate those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, the changes to decouple Torch install directory from LUA root.
LuaFromRocks.cmake will probably later go to the place where our other general CMake files go, as it's not specific to torch7 (therefore, no Torch prefix in the name).