Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Diff View Dark Mode Bug #749

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix Diff View Dark Mode Bug #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/components/LoadTemplateDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export function LoadTemplateDialog() {
<EditorActionTextButton
icon={PiShapesDuotone}
data-session-activity="Load Template: Open Dialog"
iconClassName="fill-zinc-500"
>
<Trans>Examples</Trans>
</EditorActionTextButton>
Expand Down
17 changes: 12 additions & 5 deletions app/src/components/TextEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,22 @@ export function TextEditor({ extendOptions = {}, ...props }: TextEditorProps) {
options={{
...editorOptions,
...extendOptions,
renderSideBySide: false,
renderSideBySide: true,
}}
loading={<Loading />}
theme={mode === "light" ? "vs" : "vs-dark"}
onMount={(_, monaco) => {
monaco.editor.setTheme(mode === "light" ? "vs" : "vs-dark");
}}
wrapperProps={{
"data-testid": "Editor",
className: classNames("bg-white dark:bg-neutral-900", {
"overflow-hidden": isDragging,
"cursor-wait pointer-events-none opacity-50": convertIsRunning,
}),
className: classNames(
"bg-white dark:bg-neutral-900 dark:text-white",
{
"overflow-hidden": isDragging,
"cursor-wait pointer-events-none opacity-50": convertIsRunning,
}
),
}}
/>
);
Expand Down
Loading