Expose more AEC3 params, example & test #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksongoode
force-pushed
the
upgrade-v1-aec3-tuning
branch
3 times, most recently
from
dc41a7b to
d740b36
Compare
jacksongoode
force-pushed
the
upgrade-v1-aec3-tuning
branch
from
7462722 to
51cfa88
Compare
jacksongoode
force-pushed
the
upgrade-v1-aec3-tuning
branch
from
2acf4d9 to
837bcc2
Compare
jacksongoode
force-pushed
the
upgrade-v1-aec3-tuning
branch
from
ea0ef64 to
aa214d0
Compare
strohel
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Whoa this is a lot of work @jacksongoode, thanks for it! And sorry for my very late review.
I'm adding just some little technicality suggestions, but all of them are very minor.
Comment on lines
+235
to
+246
| impl fmt::Display for AudioProcessingError { | ||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| match self { | ||
| Self::InvalidParameters => write!(f, "Invalid parameters"), | ||
| Self::ConfigValidationFailed => write!(f, "Config validation failed"), | ||
| Self::CreationFailed => write!(f, "Failed to create audio processor"), | ||
| Self::InitializationFailed(code) => write!(f, "Initialization failed: {}", code), | ||
| Self::UnknownError(code) => write!(f, "Unknown error: {}", code), | ||
| Self::CppException(code) => write!(f, "C++ exception occurred: {}", code), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Another option is to use thiserror to write these in more consice manner and have Display generated, but it won't save us much anyway. (so not advocating for that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to get most of the new params exposedI believe this exposes all of the AEC3. I added a few tests that capture and measure ERL across AEC with different configurations. I also added a module level test to made sure we have the proper props bound. Most of this was some regex transfer over from the cpp to the proper places but I could've missed some items.I added a new example with the AEC3 config which mirrors the structure of the basic karaoke example but with the ability to just pass in a config.
There's a little bit of weirdness, uncertainty around the need for an EchoCanceller to be explicitly added to the processor, I would imagine it would take a default if undefined.