chore: Implement DRY for HOOK_ID (antonbabenko#405)

tomwardill-payoneer · Jul 12, 2022 · 0f25122 · 0f25122
1 parent 2623b7b
commit 0f25122
Show file tree

Hide file tree

Showing 13 changed files with 6 additions and 30 deletions.
diff --git a/hooks/_common.sh b/hooks/_common.sh
@@ -1,6 +1,12 @@
 #!/usr/bin/env bash
 set -eo pipefail
 
+# Hook ID, based on hook filename.
+# Hook filename MUST BE same with `- id` in .pre-commit-hooks.yaml file
+# shellcheck disable=SC2034 # Unused var.
+HOOK_ID=${0##*/}
+readonly HOOK_ID=${HOOK_ID%%.*}
+
 #######################################################################
 # Init arguments parser
 # Arguments:

diff --git a/hooks/infracost_breakdown.sh b/hooks/infracost_breakdown.sh
@@ -2,9 +2,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-# shellcheck disable=SC2034 # Unused var.
-readonly HOOK_ID='infracost_breakdown'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/terraform_checkov.sh b/hooks/terraform_checkov.sh
@@ -2,9 +2,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-# shellcheck disable=SC2034 # Unused var.
-readonly HOOK_ID='terraform_checkov'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/terraform_fmt.sh b/hooks/terraform_fmt.sh
@@ -2,9 +2,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-# shellcheck disable=SC2034 # Unused var.
-readonly HOOK_ID='terraform_fmt'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/terraform_providers_lock.sh b/hooks/terraform_providers_lock.sh
@@ -3,8 +3,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-readonly HOOK_ID='terraform_providers_lock'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/terraform_tflint.sh b/hooks/terraform_tflint.sh
@@ -3,8 +3,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-readonly HOOK_ID='terraform_tflint'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/terraform_tfsec.sh b/hooks/terraform_tfsec.sh
@@ -2,8 +2,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-readonly HOOK_ID='terraform_tfsec'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/terraform_validate.sh b/hooks/terraform_validate.sh
@@ -2,9 +2,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-# shellcheck disable=SC2034 # Unused var.
-readonly HOOK_ID='terraform_validate'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/terraform_wrapper_module_for_each.sh b/hooks/terraform_wrapper_module_for_each.sh
@@ -2,10 +2,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-# shellcheck disable=SC2034 # Unused var.
-HOOK_ID=${0##*/}
-readonly HOOK_ID=${HOOK_ID%%.*}
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/terragrunt_fmt.sh b/hooks/terragrunt_fmt.sh
@@ -2,8 +2,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-readonly HOOK_ID='terragrunt_fmt'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/terragrunt_validate.sh b/hooks/terragrunt_validate.sh
@@ -2,8 +2,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-readonly HOOK_ID='terragrunt_validate'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/terrascan.sh b/hooks/terrascan.sh
@@ -2,8 +2,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-readonly HOOK_ID='terrascan'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh

diff --git a/hooks/tfupdate.sh b/hooks/tfupdate.sh
@@ -2,8 +2,6 @@
 set -eo pipefail
 
 # globals variables
-# hook ID, see `- id` for details in .pre-commit-hooks.yaml file
-readonly HOOK_ID='tfupdate'
 # shellcheck disable=SC2155 # No way to assign to readonly variable in separate lines
 readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 # shellcheck source=_common.sh