fix no-std support (replace getrandom)#19
Merged
tomtomwombat merged 1 commit intotomtomwombat:mainfrom Jan 22, 2026
Merged
Conversation
currently, even when "std" feature is not selected, various std features are still used by various crates. rand - rand::rng() finally requires "std", so make the "rand" feature automatically select it. siphasher - disable default features. getrandom - has no-std support (when its default features are not enabled), but it might actually link against various libs that might not be available (e.g. bcryptprimitives.dll - rust-random/getrandom#65) replace it with foldhash and concat 2 random u64 hashes in order to generate 128-bit seed. Signed-off-by: Eliad Peller <eliad.peller@wiz.io>
Owner
|
Thanks for catching this. So my understanding is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, even when "std" feature is not selected, various std features are still used by various crates.
rand - rand::rng() finally requires "std", so make the "rand" feature automatically select it.
siphasher - disable default features.
getrandom - has no-std support (when its default features are not enabled), but it might actually link against various libs that might not be available
(e.g. bcryptprimitives.dll - rust-random/getrandom#65)
replace it with foldhash and concat 2 random u64 hashes in order to generate 128-bit seed.