Make portRe constant #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `unfurl format %r.%t` on a long list of urls, the function `extractFromDomain()` will be called separately for each one of the urls, multiple times. This causes the same regex to be compiled multiple times: ``` portRe := regexp.MustCompile(`(?m):\d+$`) ``` Instead, portRe should be a constant. I changed the regexp to be constant and tested it on a list of 1.1 Million urls. I got the following results: Old: 0m35.384s New: 0m21.374s
its0x08
approved these changes
Jul 9, 2022
MindPatch
approved these changes
Jul 20, 2022
|
Hi @tomnomnom, Did you have the time to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
unfurl format %r.%ton a long list of urls, the functionextractFromDomain()will be called separately for each one of the urls, multiple times.This causes the same regex to be compiled multiple times:
Instead, portRe should be a constant. I changed the regexp to be constant and tested it on a list of 1.1 Million urls. I got the following results: