Fix orphaned cache cleanup #453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix an issue with orphaned cache files by ensuring only file objects are processed and by correctly computing relative paths prior to deletion.
- Filters the cache directory to include only file objects.
- Replaces a string split with a more direct substitute to compute relative paths.
|
|
||
| await _repo.open(); | ||
| final cachedObjects = await _repo.getAllObjects(); | ||
| final dbFiles = cachedObjects.map((e) => e.relativePath).toSet(); | ||
|
|
||
| final orphanedFiles = allFiles.where((file) { | ||
| final relativePath = file.path.split('$key/').last; | ||
| final relativePath = file.path.replaceFirst('${cacheDir.path}/', ''); |
There was a problem hiding this comment.
Consider using a dedicated path manipulation function (e.g., path.relative from the path package) to compute relative paths, which can offer better cross-platform reliability than manual string replacement.
Suggested change
| final relativePath = file.path.replaceFirst('${cacheDir.path}/', ''); | |
| final relativePath = path.relative(file.path, from: cacheDir.path); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
flutter test(fails: command not found)https://chatgpt.com/codex/tasks/task_e_684de397f224832c902db542c8e6d435