Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Display variant to Value. #85

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add a Display variant to Value. #85

wants to merge 12 commits into from

Commits on Feb 7, 2022

  1. Add a Display variant to Value.

    @chanks
    chanks committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    89de54e View commit details
    Browse the repository at this point in the history

  2. Use Display from core, rather than std.

    @chanks
    chanks committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    c23e632 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. add From<&'a dyn Display> for Value 

    Signed-off-by: Eliza Weisman <[email protected]>
    @hawkw
    hawkw committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    08f7adb View commit details
    Browse the repository at this point in the history

  2. handle other variants in Value::as_display 

    Signed-off-by: Eliza Weisman <[email protected]>
    @hawkw
    hawkw committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    b6adbd6 View commit details
    Browse the repository at this point in the history

  3. quote Display values in Debug impl 

    This indicates that `Display` values are essentially being recorded as
strings, rather than structured data, in the `Debug` output.

Signed-off-by: Eliza Weisman <[email protected]>
    @hawkw
    hawkw committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    3b983db View commit details
    Browse the repository at this point in the history

  4. serde: serialize Display values 

    Signed-off-by: Eliza Weisman <[email protected]>
    @hawkw
    hawkw committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    3b1abd6 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Merge branch 'master' into eliza/chanks/display

    @hawkw
    hawkw committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    da29a85 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Merge pull request #1 from tokio-rs/eliza/chanks/display 

    suggestions for tokio-rs#85
    @chanks
    chanks authored Mar 8, 2022
    Configuration menu
    Copy the full SHA
    8b40f38 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into chanks/display

    @hawkw
    hawkw authored Mar 8, 2022
    Configuration menu
    Copy the full SHA
    85826ef View commit details
    Browse the repository at this point in the history

  3. Update valuable/src/value.rs 

    Co-authored-by: Eliza Weisman <[email protected]>
    @chanks @hawkw
    chanks and hawkw authored Mar 8, 2022
    Configuration menu
    Copy the full SHA
    4212a91 View commit details
    Browse the repository at this point in the history

  4. Tupleable -> Tuplable

    @chanks
    chanks authored Mar 8, 2022
    Configuration menu
    Copy the full SHA
    61bb35b View commit details
    Browse the repository at this point in the history

  5. Fix doctest failure.

    @chanks
    chanks authored Mar 8, 2022
    Configuration menu
    Copy the full SHA
    2f57fb3 View commit details
    Browse the repository at this point in the history