fs: support io_uring in fs::write
#7567
Open
+104
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Sep 2, 2025
| } | ||
|
|
||
| #[cfg(all(tokio_uring, feature = "rt", feature = "fs", target_os = "linux"))] | ||
| async fn write_uring(path: impl AsRef<Path>, mut buf: &[u8]) -> io::Result<()> { |
There was a problem hiding this comment.
I would change both methods to take &Path and crate::util::as_ref::OwnedBuf, to avoid generics in the actual implementations.
Comment on lines
+36
to
+39
| // SAFETY: `fd` and `buf` is valid until this future completes. | ||
| // If this operation is cancelled, drop of `Op` occurs before dropping | ||
| // `fd` or `buf`, ensuring the safety contract holds. | ||
| let op = unsafe { Op::new(sqe, Write) }; |
There was a problem hiding this comment.
This logic I don't buy. Using mem::forget on the future it's possible to cause UAF. Some form of ownership is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add io-uring version of
fs::write. I think the change itself is mostly straightforward. This PR might need to coordinate with #7547 regarding the usage of cfg.Related issue: #7266