io: add tokio_util::io::simplex
#7565
Open
+396
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADD-SP
added
C-enhancement
ADD-SP
force-pushed
the
add_sp/io-alt-simplex
branch
3 times, most recently
from
ee6ae5a to
c8a39fb
Compare
Signed-off-by: ADD-SP <[email protected]>
ADD-SP
force-pushed
the
add_sp/io-alt-simplex
branch
from
c8a39fb to
43805ab
Compare
Darksonn
reviewed
Sep 2, 2025
| @@ -27,7 +27,7 @@ net = ["tokio/net"] | |||
| compat = ["futures-io"] | |||
| codec = [] | |||
| time = ["tokio/time", "slab"] | |||
| io = [] | |||
| io = ["tokio/rt"] | |||
There was a problem hiding this comment.
mm. I'd like to avoid this dependence .... could we have Tokio expose no-op methods without rt?
| Poll::Ready(Ok(())) | ||
| } else { | ||
| inner.register_receiver_waker(cx.waker()); | ||
| inner.wake_sender(); |
There was a problem hiding this comment.
I'd like to avoid calling wake() under a lock.
Comment on lines
+35
to
+41
| fn with_capacity(backpressure_boundary: usize) -> Self { | ||
| Self { | ||
| backpressure_boundary, | ||
| is_closed: false, | ||
| receiver_waker: None, | ||
| sender_waker: None, | ||
| buf: BytesMut::new(), |
There was a problem hiding this comment.
If the method is called with_capacity, then it shoud allocate that much memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design document
https://gist.github.com/ADD-SP/7558ef3965f18ce1d721dff675d01d9b
Why not deprecate the
tokio::io::simplexnow?Since the deprecation is not urgent, we can release this feature and first, and the deprecate the
tokio::io::simplexafter several months.issue: #7548