rt: add support for non-send closures for thread (un)parking #7420
+194
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
force-pushed
the
non-send-thread-park
branch
from
be90205 to
eeb45d3
Compare
Daksh14
reviewed
Jun 25, 2025
aryan9600
force-pushed
the
non-send-thread-park
branch
2 times, most recently
from
c124e08 to
4f8b562
Compare
ADD-SP
reviewed
Jun 29, 2025
There was a problem hiding this comment.
We need a test to make sure callbacks will not be executed when using the Handle::block_on.
There was a problem hiding this comment.
afaiu, we can only test this for on_thread_unpark. we can't test this for on_thread_park because if the task parks itself inside Handle::block_on, there's nothing that can call unpark() for the task.
ADD-SP
reviewed
Jun 29, 2025
aryan9600
force-pushed
the
non-send-thread-park
branch
from
4f8b562 to
fde0d15
Compare
github-actions
bot
removed
the
R-loom-current-thread
Add support for non `Send`+`Sync` closures for thread parking and unparking callbacks when using a `LocalRuntime`. Since a `LocalRuntime` will always run its tasks on the same thread, its safe to accept a non `Send`+`Sync` closure. Signed-off-by: Sanskar Jaiswal <[email protected]>
aryan9600
force-pushed
the
non-send-thread-park
branch
from
fde0d15 to
453dbd2
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for non
Send+Syncclosures for thread parking and unparking callbacks when using aLocalRuntime. Since aLocalRuntimewill always run its tasks on the same thread, its safe to accept a nonSend+Syncclosure.Motivation
Since
LocalRuntimecan run nonSend+Syncfunctions, we should accept thread parking/unparking callbacks that do not implementSendandSync.Solution
Add two methods on
LocalOptions,on_thread_parkandon_thread_unparkthat accept aFn() + 'static. These callbacks are then converted intoFn() + Send + Sync + 'static. This requires unsafe code, but unsafe is acceptable here because of the behaviour ofLocalRuntimefixes #7370