wasm: document that Tokio may use blocking ops #7207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binier
reviewed
Mar 10, 2025
| //! blocking operations when more than one thread is involved. This means that, | ||
| //! for example, using a Tokio mpsc channel to send messages from a web worker | ||
| //! to the main browser context will not work, as the main browser context does | ||
| //! not support blocking operations. |
There was a problem hiding this comment.
It's not the case just for thread -> main thread, but other way around as well. So when sending messages from main thread to other threads.
There was a problem hiding this comment.
Just this. Otherwise looks good to me. Thanks @Darksonn!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7205
cc @binier