Specialize BytesMut::put(Bytes) (alt) #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Aug 14, 2025
src/bytes_mut.rs
Outdated
| self.extend_from_slice(s); | ||
| src.advance(l); | ||
| if self.capacity() == 0 { | ||
| let src = src.copy_to_bytes(src.remaining()); |
There was a problem hiding this comment.
We should drop src before calling try_into_mut().
Suggested change
| let src = src.copy_to_bytes(src.remaining()); | |
| let src_copy = src.copy_to_bytes(src.remaining()); | |
| drop(src); |
Typical code looks like this:
```
let mut bytes = BytesMut::new();
for chunk in chunks {
bytes.put(chunk);
}
```
Avoid allocation on the first chunk. This is especially important
when there's only one chunk, which is common for short HTTP responses
for example.
stepancheg
force-pushed
the
bytes-mut-put-bytes-alt
branch
from
6a1eeae to
2860505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative version to #791.