fix(core): fix infinite retry when workspace not found #8679
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
graphite-app
bot
requested review from
CatsJuice,
forehalo,
JimmFly and
pengx17
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e8676c1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8679 +/- ##
===========================================
+ Coverage 44.96% 70.06% +25.10%
===========================================
Files 318 546 +228
Lines 7422 33809 +26387
Branches 1524 3055 +1531
===========================================
+ Hits 3337 23687 +20350
- Misses 3784 9761 +5977
- Partials 301 361 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EYHN
force-pushed
the
eyhn/fix/shared-page-workspace
branch
from
73368a7
to
e8676c1
Compare
| @@ -84,13 +84,16 @@ export const Component = (): ReactElement => { | |||
| } | |||
| }, [listLoading, meta, workspacesService]); | |||
|
|
|||
| // if workspace is not found, we should revalidate in interval | |||
| // if workspace is not found, we should retry | |||
| const retryTimesRef = useRef(3); | |||
There was a problem hiding this comment.
do we need to reset the timer when workspace id changed?
No description provided.