Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: self hosted register #6581

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from
Draft

Conversation

darkskygit
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Apr 16, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @darkskygit and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 16, 2024

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.50%. Comparing base (de40844) to head (908cd18).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6581      +/-   ##
==========================================
+ Coverage   57.48%   57.50%   +0.02%     
==========================================
  Files         903      903              
  Lines       39804    39823      +19     
  Branches     4488     4488              
==========================================
+ Hits        22880    22899      +19     
  Misses      16568    16568              
  Partials      356      356              
Flag Coverage Δ
server-test 78.19% <100.00%> (+0.01%) ⬆️
unittest 28.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo marked this pull request as draft April 16, 2024 09:24
if (config.isSelfhosted && AFFINE_ADMIN_EMAIL) {
const user = ref.get(UserService, { strict: false });
const quota = ref.get(QuotaService, { strict: false });
const { id } = (await user.findUserByEmail(AFFINE_ADMIN_EMAIL)) || {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some selfhosted server have more than one user, we should let all users use this plan

@darkskygit darkskygit force-pushed the darksky/fix-self-hosted branch 3 times, most recently from cbc9203 to 1c531d0 Compare April 18, 2024 08:40
@Felitendo
Copy link

@forehalo

@darkskygit darkskygit force-pushed the darksky/fix-self-hosted branch 2 times, most recently from 87df880 to c6774a0 Compare May 29, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants