Skip to content

Commit

Permalink
fix(server): redirect to setup page if not initialized (#7871)
Browse files Browse the repository at this point in the history
  • Loading branch information
forehalo authored Aug 14, 2024
1 parent ad42418 commit 42b5ef7
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 8 deletions.
27 changes: 20 additions & 7 deletions packages/backend/server/src/app.module.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
import { join } from 'node:path';
import { join, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';

import {
DynamicModule,
ForwardReference,
Logger,
MiddlewareConsumer,
Module,
NestModule,
} from '@nestjs/common';
import { ScheduleModule } from '@nestjs/schedule';
import { ServeStaticModule } from '@nestjs/serve-static';
Expand All @@ -16,7 +19,7 @@ import { ADD_ENABLED_FEATURES, ServerConfigModule } from './core/config';
import { DocModule } from './core/doc';
import { FeatureModule } from './core/features';
import { QuotaModule } from './core/quota';
import { CustomSetupModule } from './core/setup';
import { CustomSetupModule, SetupMiddleware } from './core/setup';
import { StorageModule } from './core/storage';
import { SyncModule } from './core/sync';
import { UserModule } from './core/user';
Expand Down Expand Up @@ -135,16 +138,26 @@ export class AppModuleBuilder {
}

compile() {
const configure = (consumer: MiddlewareConsumer) => {
if (this.config.isSelfhosted) {
consumer.apply(SetupMiddleware).forRoutes('*');
}
};

@Module({
imports: this.modules,
controllers: this.config.isSelfhosted ? [] : [AppController],
})
class AppModule {}
class AppModule implements NestModule {
configure = configure;
}

return AppModule;
}
}

const pwd = resolve(fileURLToPath(import.meta.url), '../../');

function buildAppModule() {
AFFiNE = mergeConfigOverride(AFFiNE);
const factor = new AppModuleBuilder(AFFiNE);
Expand Down Expand Up @@ -179,12 +192,12 @@ function buildAppModule() {
config => config.isSelfhosted,
CustomSetupModule,
ServeStaticModule.forRoot({
rootPath: join('/app', 'static'),
exclude: ['/admin*'],
rootPath: join(pwd, 'static', 'admin'),
renderPath: /^\/admin\/?/,
}),
ServeStaticModule.forRoot({
rootPath: join('/app', 'static', 'admin'),
serveRoot: '/admin',
rootPath: join(pwd, 'static'),
renderPath: '*',
})
);

Expand Down
35 changes: 34 additions & 1 deletion packages/backend/server/src/core/setup/index.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,42 @@
import { Module } from '@nestjs/common';
import { Injectable, Module, NestMiddleware } from '@nestjs/common';
import { PrismaClient } from '@prisma/client';
import type { Request, Response } from 'express';

import { AuthModule } from '../auth';
import { UserModule } from '../user';
import { CustomSetupController } from './controller';

@Injectable()
export class SetupMiddleware implements NestMiddleware {
private initialized: boolean | null = null;
constructor(private readonly db: PrismaClient) {}

use(req: Request, res: Response, next: (error?: Error | any) => void) {
// never throw
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.allow().then(allowed => {
if (allowed) {
next();
} else if (!req.path.startsWith('/admin/setup')) {
res.redirect('/admin/setup');
}
});
}

async allow() {
try {
if (this.initialized === null) {
this.initialized = (await this.db.user.count()) > 0;
}
} catch (e) {
// avoid block the whole app
return true;
}

return this.initialized;
}
}

@Module({
imports: [AuthModule, UserModule],
controllers: [CustomSetupController],
Expand Down

0 comments on commit 42b5ef7

Please sign in to comment.