-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a userpsace low-level debug API for Tock 2.0 #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, my comments are mostly stylistic nits.
In general, What do you think? |
My gut says no, keep it just in case, my brain says yes, errors should be silenced. I can't think of a realistic scenario where you would do something different if LowLevelDebug operations failed, since it exists for when other options fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that the low-level debug API is not exported from libtock2
. We should export it, using something like the following (in libtock2/src/lib.rs
):
pub mod low_level_debug {
type LowLevelDebug = libtock_low_level_debug::LowLevelDebug::<runtime::TockSyscalls>;
pub use libtock_low_level_debug::AlertCode;
}
This will require adding libtock_low_level_debug
as a dependency of libtock2
.
@jrvanwhy Added those exports. I considered having it be gated by a default-enabled feature in |
bors r+ |
This resolves "Implement a
LowLevelDebug
driver" in #322.