Support reading rainfall from the kernel #488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
hudson-ayers
approved these changes
Jan 17, 2025
Comment on lines
+15
to
+16
| // - `hours`: The number of hours to get the rainfall data from. 0 is the instant | ||
| // rainfall (if supported). Otherwise 1 to 24 hours are valid values. |
There was a problem hiding this comment.
I recall you removed the instant rainfall from the kernel API description, so lets remove it here as well
| // Function signature for rainfall data callback. | ||
| // | ||
| // - `arg1` (`int`): Returncode indicating status from sampling the sensor. | ||
| // - `arg2` (`int`): rainfall in hundredths of percent. |
There was a problem hiding this comment.
It seems like the description for arg2 should match the description of the rainfall argument in libtock-sync/sensors/rainfall.h?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.