lib/fetch-{libc++,newlib}: exit on error #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like we were relying on failures being silently ignored in CI: I'll push a commit that changes the invocation of |
ppannuto
approved these changes
Nov 15, 2024
|
Oof. Or... it's not an error for another day. Looks like the CI error is competing unzip's trampling each other, likely because the first unzip was only partially complete when the second one first checked if it needed to do anything :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps diagnose issues when one or more of the tools that the script requires are not installed.
In my case, I was working on a system that did not have
unzipinstalled. This error message was hidden in between a lot of other log messages, and the error was masked by a generic "can't find this header" message.This also removes the
letbindings. The bashletcommands returns exit code 1 when assigning the value0to a variable, which is ... 100% what you want, just great behavior, and definitely did not cost me another 10 minutes to debug.