Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: tocklibrary: never build with -Werror #368

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Feb 9, 2024

Our build all file adds the -Werror CFLAG, which in general is good, but when compiling a library we don't necessarily have control over the library not having any warnings. This makes CI fail when using external libraries.

Todo

But, we want to enforce no warnings on libtock. Hmm...

@lschuermann
Copy link
Member

Can't we include these libraries using -Isystem? I believe that should stop the compiler from reporting warnings for them.

@bradjc
Copy link
Contributor Author

bradjc commented Feb 9, 2024

But in this case we are compiling the library in CI, not just using it.

@ppannuto
Copy link
Member

ppannuto commented Feb 9, 2024

I suspect if we added a $$((LIBNAME)_CPPFLAGS), which makes sense for other reasons probably, and added that after all the other flags here https://github.com/tock/libtock-c/blob/master/TockLibrary.mk#L102-L109, then you could add -Wno-error to those library flags. IIRC, last-flag has precedence in gcc when there is otherwise conflicts.

@lschuermann lschuermann added this pull request to the merge queue Mar 5, 2024
Merged via the queue into master with commit 38ee4e0 Mar 5, 2024
4 checks passed
@lschuermann lschuermann deleted the library-werror branch March 5, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants