Update the HOTP App to use Key Value Store #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
approved these changes
Sep 20, 2023
|
Looks ok besides the CI failure. Should we add a README to this? |
- use \r or \n - add more error print - use console OR USB HID
Readme is part of the tutorial in the tock book. |
Let's point to that in the README then |
|
It looks like there's already a README which points to the Tock Book: https://github.com/tock/libtock-c/blob/3c7a601d06612c9a1132fd85ebd91f79ff0bfae0/examples/tutorials/hotp/hotp_oracle_complete/README.md |
brghena
approved these changes
Nov 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alistair23
approved these changes
Dec 4, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tyler-potyondy
pushed a commit
to tyler-potyondy/libtock-c
that referenced
this pull request
Mar 13, 2024
Update the HOTP App to use Key Value Store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the HOTP app to use KV rather than app state.
Advantages of KV:
This also just prints the code if usb-hid isn't set up.
I tested this with an nrf52840dk board and it seemed to work as expected. The programmed keys continued to work after resets.