Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support comma as delimiter for “@tpm_plugins” #238

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support comma as delimiter for “@tpm_plugins” #238

wants to merge 2 commits into from

Conversation

FranklinYu
Copy link
Contributor

Notes:

  1. Empty elements will be ignored.
  2. Double slash means global replacement. See Bash manual.

@FranklinYu
Support comma as delimiter for “@tpm_plugins”
1a25c5c 
Note that empty elements will be ignored.
@FranklinYu FranklinYu mentioned this pull request Jan 4, 2023
Open
@FranklinYu
Copy link
Contributor Author

Hello? Any news?

@bruno-
Copy link
Member

bruno- commented Apr 6, 2023

Hi,

I'm in favor of accepting this. Can you please check the comments? I'll merge after you address them.

@FranklinYu
Copy link
Contributor Author

(Appended a commit for easier review; I assume you would squash them when merging. Please let me know if you’d rather I do the squashing.)

@FranklinYu
Copy link
Contributor Author

Hi there, any feedback after my last commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno- bruno- bruno- left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FranklinYu @bruno-