Removed Ring patch + updated wasm-bindgen #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should depend on tlsnotary/tlsn#391 (review) |
mhchia
reviewed
Dec 7, 2023
Co-authored-by: Kevin Mai-Husan Chia <[email protected]>
mhchia
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Just tried this branch and the extension worked well. This PR should be ready. Thanks a lot for your work 🙏
Note: I first encountered an error complaining about env stuff, indicating an old ring was used because an old tlsn was used. Just needed to update the Cargo.lock by running cargo update and it was resolved.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.