Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add progress for notarization request and resurface error message #119

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

0xtsukino
Copy link
Collaborator

progress-bar

@0xtsukino 0xtsukino changed the title feat: add progress for notarization request feat: add progress for notarization request and resurface error message Dec 4, 2024
@heeckhau
Copy link
Member

heeckhau commented Dec 5, 2024

@0xtsukino you video looks amazing 💯

  • When I compile this I only see this until it is ready:
image
  • And how did you pick the different phases? 1 and 2 flash by, same with 5.
    Maybe:

    1. Setup Prover
    2. Setup MPC with Notary
    3. Send request
    4. Commit to transcript and wait for attestation
  • Can we show progress in the sidebar too?

@0xtsukino
Copy link
Collaborator Author

pbar

@heeckhau heeckhau merged commit 846bc1e into main Jan 28, 2025
2 checks passed
@heeckhau heeckhau deleted the pbar branch January 28, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants