permissions: UI + Storybook #196
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomholford
force-pushed
the
t/storybook
branch
2 times, most recently
from
d08bf1e to
824a4f9
Compare
tomholford
force-pushed
the
t/storybook
branch
3 times, most recently
from
ccca0f6 to
31b1cac
Compare
- Fix icons - Rename WarningBanner - Update styles - Create new Component
also: - extract functions to hooks in docket - use routes to render perm dialog - add fake seal placeholder - iterate on
also, render permission details using epxandable summary rows
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is part of an ongoing effort to implement Userspace Permissions UI (#182).
This effort is in parallel to finishing the API interface (see: #195)
Resolves #178
Resolves #179
Resolves #180
Changes
npm run storybook)Preview
Happy Path
userspace_permissions.mov
WarningBanner
SummaryRow
PermissionsDialog