Security fix for Rust idna crate - CVE-2024-12224 #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
As flagged in https://github.com/tkhq/qos/security/dependabot/41 and https://github.com/tkhq/qos/security/dependabot/42, the
idnacrate needs patches, see GHSA-h97m-ww89-6jmq.This requires upgrading the
urlandhickory-protocrates, which bring their own dependency updates.I reviewed the newly pulled in or updated dependency code crate today, for versions of crates that are not already in use in important upstream projects. I think the new code is non-malicious. Review depth varied, since the unicode crates are very dense and big, with many binary snippets. For more information, see the internal PR documentation.
How I Tested These Changes
Not tested. Please test carefully before deployment.