Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-fuzz test harness for the qos_p256 crate #439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cr-tk
Copy link
Collaborator

@cr-tk cr-tk commented Mar 7, 2024

Summary & Motivation (Problem vs. Solution)

Add some fuzzing test coverage of basic qos_p256 functions.

How I Tested These Changes

Running the fuzz tests locally.
No change to production code.

Pre merge check list

Does not apply.

@cr-tk cr-tk added the enhancement New feature or request label Mar 7, 2024
@cr-tk cr-tk self-assigned this Mar 7, 2024
@cr-tk cr-tk force-pushed the christian/qos_p256_fuzz1 branch 4 times, most recently from 2bb6cc1 to 2416339 Compare March 8, 2024 19:12
@cr-tk cr-tk force-pushed the christian/qos_p256_fuzz1 branch from 2416339 to 9d9cc90 Compare December 21, 2024 22:11
@cr-tk cr-tk marked this pull request as ready for review December 21, 2024 22:12
@cr-tk cr-tk requested review from a team as code owners December 21, 2024 22:12
@cr-tk
Copy link
Collaborator Author

cr-tk commented Dec 21, 2024

I re-worked and improved the fuzz harnesses, and this PR is now ready for review.

Extra note for dependency review: this review requirement gets triggered (correctly) due to changes in the Cargo.toml in the fuzz subdirectory (sub-crate). This change does not directly affect production code since the fuzz tests are deliberately separate, also see the workspace exclusion. However, they are relevant for developer security.
The good news there is that all necessary Rust dependencies are already present (libfuzzer-sys, arbitrary, ...) from other fuzz harness work, so there's no change to the Cargo.lock files and therefore no new external code that requires review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant