Add Quorum Key Resharding Service #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
force-pushed
the
zeke-reshard-4
branch
3 times, most recently
from
bc26255 to
0ff98e8
Compare
wip wip get to compile Initial reshard provision and unit test code clean up fix n choose k refactor n choose k Finish tests for reshard add test for boot reshard Add generate reshard input wip wip wip wip Get reshard-renencrypt working Get post share working lint wip Build get reshard output Add new secrets for file key get full thing working e2e refactor wip get qos core to compile Get all of qos core working refactor to not use quorumpubkey wrapper wip Get e2e tests working with new input Add logic for checking that e2e share recombination works finish integration test lint stuff Improve human verifiactions clean up
emostov
force-pushed
the
zeke-reshard-4
branch
from
0ff98e8 to
b3f7469
Compare
emostov
added a commit
that referenced
this pull request
Apr 18, 2024
|
Superseded by #446 |
emostov
added a commit
that referenced
this pull request
Apr 22, 2024
emostov
added a commit
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
chacha::ChaChaRng::from_entropy(); make sure to removethread_rngusage.Summary & Motivation (Problem vs. Solution)
QOS users need a way to reshard quorum keys.
This PR solves the issue by adding a new boot mode specifically for resharding keys. The process is similar to running a boot standard, in that members from the share set need to post shares to reconstruct the quorum keys. Once quorum keys are reconstructed, they are resharded to the new share set. New share set members can then pull their shares and verify that they can decrypt them.
Prior to reviewing the code in detail, take a look at
src/qos_client/RESHARD_GUIDE.md, which describes how to execute quorum key reshardingHow I Tested These Changes
Pre merge check list