feat: add support for EIP-191 message signing with secp256k1 #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new signature scheme `SchemeSECP256K1EIP191` for EIP-191 compliant message signing. - Implemented a new `ecdsaEIP191Key` type to handle EIP-191 signing logic. - Updated the `sign` method to generate EIP-191 compliant signatures using the Keccak256 hash function. - Modified the key creation logic to accommodate the new signing scheme.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…EIP-191 message signing using golang.org/x/crypto/sha3 instead.
…emented EIP-191 message signing using golang.org/x/crypto/sha3 instead." This reverts commit 288c2ab.
…EIP-191 message signing using golang.org/x/crypto/sha3 instead.
wnxd
commented
Jan 21, 2026
Author
wnxd
left a comment
wnxd
left a comment
There was a problem hiding this comment.
Introduced a new signature scheme SchemeSECP256K1EIP191 for EIP-191 compliant message signing.
Implemented a new ecdsaEIP191Key type to handle EIP-191 signing logic.
Updated the sign method to generate EIP-191 compliant signatures using the Keccak256 hash function.
Modified the key creation logic to accommodate the new signing scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SchemeSECP256K1EIP191for EIP-191 compliant message signing.ecdsaEIP191Keytype to handle EIP-191 signing logic.signmethod to generate EIP-191 compliant signatures using the Keccak256 hash function.