Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra setup for recovery and export frames #11

Merged
merged 19 commits into from
Nov 1, 2023
Merged

Infra setup for recovery and export frames #11

merged 19 commits into from
Nov 1, 2023

Conversation

r-n-o
Copy link
Collaborator

@r-n-o r-n-o commented Oct 30, 2023

This PR has the basics:

  • a new Dockerfile which installs and starts an nginx server, serving recovery and export frames on 2 different ports (8080, 8081)
  • a new workflow to publish docker images to GHCR
  • a new kustomize folder with configuration to define a service

Testing

  • I have tested the Dockerfile locally, it works.
  • I have published an image to ghcr
  • I've also pulled that same image and ran it in a local k3d cluster

Next step: run this in our preprod cluster!

@r-n-o r-n-o requested a review from james-callahan October 30, 2023 17:21
Copy link
Contributor

@james-callahan james-callahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I don't think you actually need 2 server blocks here; you could just have two location blocks?
  2. The container as written is non-reproducible; you might be able to get away with using a direct nginx upstream container? (it's no worse than the debian one...)

.github/workflows/publish-container.yml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
nginx.conf Outdated Show resolved Hide resolved
@r-n-o
Copy link
Collaborator Author

r-n-o commented Oct 30, 2023

I don't think you actually need 2 server blocks here; you could just have two location blocks?

I need two server blocks if I want to serve on different ports (listen directive's only context is server: https://nginx.org/en/docs/http/ngx_http_core_module.html#listen)

The container as written is non-reproducible; you might be able to get away with using a direct nginx upstream container? (it's no worse than the debian one...)

Would switching to a direct nginx upstream solve the reproducibility problem, or is that a separate problem (as in: problem 1: container is not reproducible, problem 2: could simplify the dockerfile by using a direct upstream container).

.vscode/settings.json Outdated Show resolved Hide resolved
kustomize/cluster.yaml Outdated Show resolved Hide resolved
kustomize/kustomization.yaml Outdated Show resolved Hide resolved
kustomize/kustomization.yaml Outdated Show resolved Hide resolved
kustomize/kustomization.yaml Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
nginx.conf Show resolved Hide resolved
nginx.conf Outdated Show resolved Hide resolved
@r-n-o r-n-o requested a review from drGrove November 1, 2023 15:39
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@r-n-o r-n-o requested a review from james-callahan November 1, 2023 17:33
Dockerfile Show resolved Hide resolved
@r-n-o r-n-o dismissed drGrove’s stale review November 1, 2023 18:12

Addressed comments

@r-n-o r-n-o merged commit fc591f8 into main Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants