Skip to content

Commit

Permalink
update sigma
Browse files Browse the repository at this point in the history
  • Loading branch information
tjdiamandis committed Aug 18, 2023
1 parent 0004913 commit d186994
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion benchmarks/2-logistic.jl
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ function build_genios_conic_model(A, b, λ1)
c = zeros(size(M, 1))
K = GeNIOS.ProductCone(vcat(K1, K2, K3, K4, K5, K6))

return GeNIOS.ConicSolver(P, q, K, M, c)
return GeNIOS.ConicSolver(P, q, K, M, c; σ=0.0)
end


Expand Down
2 changes: 1 addition & 1 deletion benchmarks/3-huber.jl
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ function run_trial(n)

# compile
solve!(GeNIOS.QPSolver(P, q, Aqp, l, u); options=GeNIOS.SolverOptions(max_iters=2, verbose=false))
solver_qp = GeNIOS.QPSolver(P, q, Aqp, l, u)
solver_qp = GeNIOS.QPSolver(P, q, Aqp, l, u; σ=0.0)
options_qp = GeNIOS.SolverOptions(
verbose=false,
relax=true,
Expand Down
4 changes: 2 additions & 2 deletions benchmarks/4-constrained-ls-compare.jl
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function run_trial(n::Int)
# GeNIOS solve
# With everything
GC.gc()
solver = GeNIOS.QPSolver(P, q, A, l, u)
solver = GeNIOS.QPSolver(P, q, A, l, u; σ=0.0)
options = GeNIOS.SolverOptions(
verbose=false,
precondition=true,
Expand All @@ -91,7 +91,7 @@ function run_trial(n::Int)

# No preconditioner
GC.gc()
solver_npc = GeNIOS.QPSolver(P, q, A, l, u)
solver_npc = GeNIOS.QPSolver(P, q, A, l, u; σ=0.0)
options = GeNIOS.SolverOptions(
verbose=false,
precondition=false,
Expand Down
7 changes: 3 additions & 4 deletions benchmarks/5-portfolio.jl
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ function run_trial(n::Int; solvers=[:qp, :op, :custom, :cosmo_indirect, :cosmo_d

if :qp solvers
GC.gc()
solver = GeNIOS.QPSolver(P_eq, q_eq, M_eq, l_eq, u_eq)
solver = GeNIOS.QPSolver(P_eq, q_eq, M_eq, l_eq, u_eq; σ=0.0)
result_qp = solve!(solver; options=options)
else
result_qp = nothing
Expand All @@ -183,7 +183,7 @@ function run_trial(n::Int; solvers=[:qp, :op, :custom, :cosmo_indirect, :cosmo_d
q = -μ
l = vcat(zeros(n), ones(1))
u = vcat(Inf*ones(n), ones(1))
solver = GeNIOS.QPSolver(P, q, M, l, u)
solver = GeNIOS.QPSolver(P, q, M, l, u; σ=0.0)
result_qp_full = solve!(solver; options=options)
else
result_qp_full = nothing
Expand All @@ -200,7 +200,7 @@ function run_trial(n::Int; solvers=[:qp, :op, :custom, :cosmo_indirect, :cosmo_d
l = vcat(zeros(n), ones(1))
u = vcat(Inf*ones(n), ones(1))

solver = GeNIOS.QPSolver(P, q, M, l, u; check_dims=false);
solver = GeNIOS.QPSolver(P, q, M, l, u; check_dims=false, σ=0.0);
result_op = solve!(solver; options=options)
else
result_op = nothing
Expand Down Expand Up @@ -384,7 +384,6 @@ timing_plt = plot(
yaxis=:log,
xaxis=:log,
label=["GeNIOS (eq qp)" "GeNIOS (full qp)" "GeNIOS (cust ops)" "GeNIOS (GenericSolver)" "COSMO (indirect)" "COSMO (direct)" "OSQP" "Mosek"],
# label=["GeNIOS (eq qp)" "GeNIOS (full qp)" "GeNIOS (cust ops)" "GeNIOS (GenericSolver)"],
xlabel=L"Problem size $n$",
ylabel="Total solve time (s)",
legend=:bottomright,
Expand Down

2 comments on commit d186994

@tjdiamandis
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/89897

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.0 -m "<description of version>" d186994c83e61edfce1dc0d3c4c9c111c8e935f8
git push origin v0.1.0

Please sign in to comment.