feat: Don't wrap the original Promise #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubzzz
changed the title
sheremet-va
requested changes
May 17, 2024
test/index.test.ts
Outdated
| expect(caughtError).toBeInstanceOf(Error) | ||
| expect(caughtError?.message).toEqual('async error') | ||
| }) | ||
|
|
||
| test.only('async order preserved', async () => { |
There was a problem hiding this comment.
.only are not allowed, not sure why CI doesn't fail
dubzzz
commented
May 17, 2024
I can but I'll have a limited availability until Monday included |
|
And I'll need pointers |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR opened following a discussion with @sheremet-va on #44. I squashed all my commits together before opening the PR.