builder: order embedded files deterministically #5193
Merged
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasnaur
force-pushed
the
push-xsztontrypyt
branch
from
5c6769f to
4dd7e98
Compare
Member
|
Seems like a good idea to me, and all the tests pass. Anyone else have any comments here? |
aykevl
approved these changes
Feb 11, 2026
Member
aykevl
left a comment
aykevl
left a comment
There was a problem hiding this comment.
LGTM, and yes this fixes a bug (the output is supposed to be deterministic)
Member
|
Thanks for the fix @eliasnaur and for review @aykevl now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the linker output will differ according to the random iterator order of Go maps.