fix smoketest failures on examples/net examples #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent PAHO MQTT package updates brought in new Gorilla package and dependencies on net/http/httptrace and crypto/tls, which aren't ported over the TinyGo's net package. I'll open an Issue against the TinyGo's net package to port the missing dependencies. Until that happens, disable the test in smoketest so smoketest will pass. The other MQTT example (examples/net/mqttclient/natiu) works fine and remains in the smoketest.
|
Added tinygo-org/net#10 to fix the missing paho/mqtt dependencies. |
|
What about all the other examples that I mentioned in tinygo-org/net#9 sounds like that is all the same issue? |
I'll take a look at that one in the morning. Probably some issue when converting to netip API. |
|
Thanks @scottfeldman |
|
I believe tinygo-org/net#9 is fixed with tinygo-org/net/pull/11 |
|
Thanks for the fixes @scottfeldman now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examples/net/socket test was failing because of missing updates to recent net/netip changes to netdev interface. Oops!
examples/net/mqttclient/paho was failing because of new dependencies brought in by paho package that haven't been ported to TinyGo's net package. Will open an issue on tinygo-org/net to fix the dependencies.