Skip to content

Linux: Fix unsubscribe from characteristic notifications issue #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aventari wants to merge 2 commits into from
Closed

Linux: Fix unsubscribe from characteristic notifications issue #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8b9dd9
Update gattc_linux.go to properly unsubscribe from notifications usin…
aventari Oct 28, 2025
d1d45dd
Update package name and all references to aventari from tinygo.org
Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bluetooth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
// those produced by Nordic Semiconductor.
//
// This package can be use to create Bluetooth Low Energy centrals as well as peripherals.
package bluetooth // import "tinygo.org/x/bluetooth"
package bluetooth // import "github.com/aventari/bluetooth"
2 changes: 1 addition & 1 deletion examples/advertisement/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"
"time"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var adapter = bluetooth.DefaultAdapter
Expand Down
2 changes: 1 addition & 1 deletion examples/battery/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"math/rand"
"time"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var adapter = bluetooth.DefaultAdapter
Expand Down
2 changes: 1 addition & 1 deletion examples/beacon/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"math/rand"
"time"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var adapter = bluetooth.DefaultAdapter
Expand Down
2 changes: 1 addition & 1 deletion examples/circuitplay/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"machine"
"time"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
"tinygo.org/x/drivers/ws2812"
)

Expand Down
2 changes: 1 addition & 1 deletion examples/connparams/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ package main
import (
"time"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var (
Expand Down
2 changes: 1 addition & 1 deletion examples/device-information/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package main
import (
"time"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var adapter = bluetooth.DefaultAdapter
Expand Down
2 changes: 1 addition & 1 deletion examples/discover/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ package main
import (
"strconv"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var adapter = bluetooth.DefaultAdapter
Expand Down
2 changes: 1 addition & 1 deletion examples/heartrate-monitor/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
package main

import (
"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var (
Expand Down
2 changes: 1 addition & 1 deletion examples/heartrate/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"math/rand"
"time"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var (
Expand Down
2 changes: 1 addition & 1 deletion examples/ledcolor/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"machine"
"time"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var adapter = bluetooth.DefaultAdapter
Expand Down
4 changes: 2 additions & 2 deletions examples/nusclient/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ package main
// details.

import (
"tinygo.org/x/bluetooth"
"tinygo.org/x/bluetooth/rawterm"
"github.com/aventari/bluetooth"
"github.com/aventari/bluetooth/rawterm"
)

var (
Expand Down
4 changes: 2 additions & 2 deletions examples/nusserver/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ package main
// Code to interact with a raw terminal is in separate files with build tags.

import (
"tinygo.org/x/bluetooth"
"tinygo.org/x/bluetooth/rawterm"
"github.com/aventari/bluetooth"
"github.com/aventari/bluetooth/rawterm"
)

var (
Expand Down
2 changes: 1 addition & 1 deletion examples/scanner/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package main

import (
"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var adapter = bluetooth.DefaultAdapter
Expand Down
2 changes: 1 addition & 1 deletion examples/stop-advertisement/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ package main
import (
"time"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

var adapter = bluetooth.DefaultAdapter
Expand Down
2 changes: 1 addition & 1 deletion examples/tinyscan/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"image/color"
"time"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
"tinygo.org/x/tinyterm"
)

Expand Down
13 changes: 10 additions & 3 deletions gattc_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,12 +277,19 @@ func (c *DeviceCharacteristic) EnableNotifications(callback func(buf []byte)) er
if c.property == nil {
return nil
}

err := c.adapter.bus.RemoveMatchSignal(c.propertiesChangedMatchOption)
// Make the D-Bus call to stop notifications on the characteristic.
stopNotifyErr := c.characteristic.Call("org.bluez.GattCharacteristic1.StopNotify", 0).Err
// Still clean up other resources if there was an error
removeSignalErr := c.adapter.bus.RemoveMatchSignal(c.propertiesChangedMatchOption)
c.adapter.bus.RemoveSignal(c.property)
close(c.property)
c.property = nil
return err

// If there were errors, prioritize notify err
if stopNotifyErr == nil {
return removeSignalErr
}
return stopNotifyErr
}
}

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module tinygo.org/x/bluetooth
module github.com/aventari/bluetooth

go 1.22.1

Expand Down
2 changes: 1 addition & 1 deletion tools/gen-characteristic-uuids/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
"golang.org/x/text/cases"
"golang.org/x/text/language"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

type Characteristic struct {
Expand Down
2 changes: 1 addition & 1 deletion tools/gen-service-uuids/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
"golang.org/x/text/cases"
"golang.org/x/text/language"

"tinygo.org/x/bluetooth"
"github.com/aventari/bluetooth"
)

type Service struct {
Expand Down
Loading