This repository was archived by the owner on Oct 27, 2025. It is now read-only.
🐛 Bugfix - Adjusted default values of icon field in components #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Features and Hero components
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue
This PR addresses a bug where on several components when adding items containing icon fields, while not changing their default value, would be unable to save and receive an error "unable to addressShape".
This was due to the default values provided being incorrect, boolean in two cases and empty strings in features.
This was simply addressed by providing correct default values on all affected components. If logos are not desired by default this field can be removed safely from the default values on the components.