Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to mark FormField and FormGroup as PRISTINE #49

Merged

Conversation

crapStone
Copy link
Contributor

This PR adds methods to both FormGroup and FormField that marks them as PRISTINE to reset the dirty flag.

@crapStone crapStone changed the title add method to mark FormField and FormGroup as PRISTINE Add method to mark FormField and FormGroup as PRISTINE Nov 7, 2024
Copy link
Owner

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I added a comment to rename the method to keep it consistent.

packages/platform/src/lib/form-group.ts Outdated Show resolved Hide resolved
packages/platform/src/lib/form-group.ts Outdated Show resolved Hide resolved
Copy link
Owner

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crapStone !

@timdeschryver timdeschryver merged commit d702b31 into timdeschryver:main Nov 8, 2024
2 checks passed
Copy link

github-actions bot commented Nov 8, 2024

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants