Refactor Timers #500
Merged
Refactor Timers #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection. Moved timers and factories to `Proto.Timers` namespace.
timcassell
force-pushed
the
timers
branch
3 times, most recently
from
23ec65a to
3e3c95e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #474.
Wrap
ITimerSourcetimers in aTimerstruct.Moved timers and factories to
Proto.Timersnamespace.I was unhappy with exposing
IPoolableTimerdirectly, as it lacks any improper use detection. Wrapping it in a struct and passing along a token helps with that, just like all the other types in the library (the difference here is the interface is public, so users can provide their own implementations, similar toValueTask).