Create nuget package for Unity helpers. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #125.
This also removes assigning the
UnitySynchronizationContextto theForegroundContextin edit mode (from #120), because Nuget only hosts compiled dlls, so we can't use conditional compilation for editor-only APIs. I do not want the Nuget package to diverge behaviorally from the Unity package. That means users will have to manually set theForegroundContextin edit mode if they want to schedule continuations on the main thread.I also cleaned up some of the code which may possibly break some users code if they were directly using any of the
MonoBehaviours (like referencingPromiseBehaviourwhich I made internal, or usingPromiseYielderas an object, which I changed to a static class). Those use cases never would have been recommended in any case, so I think it is worth breaking them for a minor version update.