Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Nuget package for Unity helpers #125

Closed
timcassell opened this issue Sep 18, 2022 · 0 comments · Fixed by #127
Closed

Separate Nuget package for Unity helpers #125

timcassell opened this issue Sep 18, 2022 · 0 comments · Fixed by #127
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@timcassell
Copy link
Owner

RestClient for Unity is interested in adopting ProtoPromise proyecto26/RestClient#216. They have a Nuget package with UnityEngine dependencies. The ProtoPromise Nuget package does not have any UnityEngine dependencies so that it can work on any .Net platform.

We do have some UnityEngine depencies in the UnityPackage for helpers like converting coroutines to Promises and executing the PromiseSynchronizationContext for foreground scheduling. Obviously, I would recommend just using the UnityPackage for source code, but we should create a separate Nuget package that contains those Unity helpers with the UnityEngine.dll dependency so that RestClient and other Unity-based libraries who wish to use ProtoPromise and host their package on Nuget can add a dependency to that helper package.

@timcassell timcassell added the enhancement New feature or request label Sep 18, 2022
@timcassell timcassell added this to the v2.3.0 milestone Sep 18, 2022
@timcassell timcassell self-assigned this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant