Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to NuMongoDB #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Changes to NuMongoDB #1

wants to merge 4 commits into from

Conversation

diederikh
Copy link

Hi Tim,

I have made some changes to in my fork of NuMongoDB as I am using NuMongoDB for DiskLibrary 2 (still in development). I was previously using the C++ driver.

Let me know what you think...

Thanks,
Diederik Hoogenboom
Obvious Matter

Diederik Hoogenboom added 3 commits January 30, 2011 14:43
- Added support for storing NSImages
- Added support for regular expressions in the NSDictionary to BSON conversion
- Added support for GC in the NuBSON class
- Added convenience method for FindAndModify
- Fixed some issues with GridFS
@timburks
Copy link
Owner

Hi Diederik, I'm glad that NuMongoDB was useful to you. Thanks for the additions! I have not used gridfs yet but think this is good to include. I want to look over your changes a bit more to understand them, but I expect that I'll pull these with no problem.

A question for you: I have an uncommitted change that automatically adds _created and _updated timestamps to documents that are inserted or updated with NuMongoDB. Would this cause problems for you?

@diederikh
Copy link
Author

Hi,

Well, I am storing millions of documents in MongoDB for my app (it's a disk cataloging application). So adding extra fields will make a big difference in DB size. If you can make it optional (property on NuMongoDB class or so) that would be great.

About reviewing the code: I did made some changes to get NuMongoDB to work under garbage collection. Especially the NuBSON bson_for_object: was giving me trouble as it creates an NuBSON object and then in the same scope GC will destroy the object and thus releasing the bsonvalue (while is will be used later). You may want to look at that more closely to see if a more elegant solution can be found.

Thanks,

Diederik

…Dictionary (Thanks to telennon for the updates)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants