-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rework of PHP files. #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these improvements and moving PHP files more towards our Timber standard.
I found some things to look at and I added separate comments for those.
@gchtr , I went over all your requests. As mentioned, I would like to discuss how the starter theme should look like but all other items are done! |
@Levdbas Thanks for the updates! This looks good to me. Hit me up with anything you want to discuss :): |
This is the first changes in a larger set of changes that I am going to propose.
Related:
Issue
Since the creation of the starter theme a lot has happened in PHP, WordPress and Timber. I want to make the starter-theme a more modern starting point for custom theme development.
Solution
This particular PR focusses on overhauling the PHP files to:
Impact
A better, less confusing, start with templating in Timber.
Usage Changes
Code is now namespaced, so people will have to add filters/actions with a namespace reference as well. In a next PR I will also solely focus on the starttheme class.
Considerations
This is not adhering to any code style yet, I would like to introduce that soon as well and thus lint the whole codebase.
Testing
I might try to add some overall tests in the upcoming few PR's