Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cfg-if requirement from ^0.1 to ^1.0 #362

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 3, 2020

Updates the requirements on cfg-if to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [cfg-if](https://github.com/alexcrichton/cfg-if) to permit the latest version.
- [Release notes](https://github.com/alexcrichton/cfg-if/releases)
- [Commits](rust-lang/cfg-if@0.1.1...1.0.0)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 3, 2020
Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In regards to the Fossa license checks: I don't think the failures are directly related to this pull request as the license of cfg-if is compliant. In order to access details of the Fossa complaints I would need to grant Fossa write access which I am reluctant to do.

This project is licensed under either of

at your option.

@lucab
Copy link
Member

lucab commented Nov 3, 2020

@zhouqiang-cl I think the red marks here are related to #348, can you please check what's the issue? (I think it is complaining about pre-existing issues, but I can't see which ones)

@zhouqiang-cl
Copy link

zhouqiang-cl commented Nov 3, 2020

I disable fossa check now, ignore the fossa check

@mxinden mxinden merged commit 4ac9b20 into master Nov 3, 2020
@dependabot dependabot bot deleted the dependabot/cargo/cfg-if-tw-1.0 branch November 3, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants