Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: skip evict-leader-scheduler when setting schedule deny label #8942

Open
wants to merge 1 commit into
base: feature/release-7.5.1-20241126
Choose a base branch
from

Conversation

HaoW30
Copy link

@HaoW30 HaoW30 commented Dec 20, 2024

This commit comes from https://github.com/tikv/pd/commit/463297be6a621183386105525e0aa33a5fc09ebd.patch

DO NOT MERGE

What problem does this PR solve?

For testing

Issue Number: Close #xxx

What is changed and how does it work?

PD FIX

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below) x
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

Nothing

NOT FOR RELEASE

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lhy1024 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

Hi @HaoW30. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. dco-signoff: no Indicates the PR's author has not signed dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2024
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 20, 2024
@ti-chi-bot
Copy link
Member

Now you can start all CI jobs with /test all in comment or query the triggers with /test ?

@HaoW30
Copy link
Author

HaoW30 commented Dec 20, 2024

/ok-to-test

@HaoW30
Copy link
Author

HaoW30 commented Dec 20, 2024

/test all

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Dec 20, 2024
@HaoW30
Copy link
Author

HaoW30 commented Dec 20, 2024

/test all

@rleungx rleungx added the status/DNM Do not merge this PR. label Dec 20, 2024
@HaoW30
Copy link
Author

HaoW30 commented Dec 20, 2024

/test

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

@HaoW30: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test build
/test integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/release-8.1/ghpr_build

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/DNM Do not merge this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants