txnkv: introduce ballast object for batch-get worker #1535
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch-get may spawn multiple goroutines to fetch keys. There is notable cost on stack growing.
After some analysis, it shows the batch-get worker requires 8KB stack size currently, that is, the stack will grow to 4KB, then 8KB for each worker groutine. To reduce the overhead, we can introduce a ballast object to let the stack grow to 8KB directly at the begining of the goroutine.
The benchmark results show that it helps improve performance.
BTW, I also tried to use the internal goroutine pool of kvstore, but the test result is not good, the overhead of selectgo is significant, and default 128 pool size is not enough to prevent new goroutines.