Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve error handling when failed to load pnpm-sync.json #35

Merged
merged 2 commits into from
Jun 10, 2024
Merged

feat: improve error handling when failed to load pnpm-sync.json #35

merged 2 commits into from
Jun 10, 2024

Conversation

chengcyber
Copy link
Member

Summary

Improve error handling when loading the existing .pnpm-sync.json

Detail

There a edge case when writing .pnpm-sync.json fails. This may leave a empty .pnpm-sync.json file. pnpm-sync complains about invalid JSON when loading the current .pnpm-sync.json file.

Actual:
image

image

Expected: No error

@chengcyber chengcyber requested a review from g-chao June 8, 2024 07:47
g-chao
g-chao approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@g-chao g-chao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@g-chao g-chao merged commit 3685a49 into main Jun 10, 2024
2 checks passed
@g-chao g-chao deleted the feat-prepare-load branch June 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-chao g-chao g-chao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chengcyber @g-chao