feat: use PNPM logic to process depPathToFilename #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-chao
force-pushed
the
chao/depPathToFilename
branch
from
ef53ede
to
2223563
Compare
octogonz
reviewed
Apr 9, 2024
octogonz
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is an issue with the "targetFolder" in the ".pnpm-sync.json" file generated by pnpm-sync-lib. It is parsed from the "pnpm-lock" file, but the actual path used by pnpm is truncated and partially replaced with a hash due to the original path being too long.
It turns out there is an official PNPM package
@pnpm/dependency-paththat can help with this situation. https://github.com/pnpm/pnpm/blob/f7537b87f4346991a773f1cd039836bb67726861/packages/dependency-path/src/index.ts#L122