Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support version in .pnpm-sync.json #23

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

g-chao
Copy link
Collaborator

@g-chao g-chao commented Apr 3, 2024

Summary

This PR is to fix #22. Add a version field in the .pnpm-sync.json.

Details

  1. The version in the package.json file will be written into .pnpm-sync.json.
  2. During pnpm-sync prepare, if an outdated version detected, then the .pnpm-sync.json file will be generated from scratch.
  3. During pnpm-sync copy, if an outdated version detected, then pnpm-sync will throw an error notify users to regenerate the .pnpm-sync.json

How it was tested

Tested with test cases under tests/pnpm-sync-api-test

@g-chao g-chao merged commit e7de747 into main Apr 9, 2024
2 checks passed
@g-chao g-chao deleted the chao/support-versioning branch April 9, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.pnpm-sync.json should be versioned.
2 participants